zcash: 2.1.1-1 -> 4.1.1; fix build #107184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is pretty much a repackaging, because a lot has changed about zcash in two major versions. Lots of libraries are no longer necessary, and librustzcash is now part of the zcash package as opposed to being a library supposed to be built seperately. The whole thing is a buildRustPackage because that's easier than trying to emulate buildRustPackage's dependency setup behaviour inside a normal mkDerivation. So that the normal zcash build process is followed, the actual configuring and building uses the normal stdenv behaviour.
|
Result of 1 package built:
|
|
Builds and basic things like printing help work fine, I will run try and sync to the mainnet over the weekend and verify that it all works fine. LGTM so far Thank you for fixing this! I gave it a shot some weeks ago but realized it would need to be a rewrite and shelved it. |
prusnak
approved these changes
Dec 19, 2020
|
Since you are rewriting the whole thing, maybe you can also use
`nixpkgs-fmt` formatter to re-format the code (mainly to put
dependencies on separate lines, making further reviews easier).
I find that style very hard to read, and it's inconsistent with all the
examples in the manual, so I'm going to leave it as it is.
|
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
|
@RaghavSood did you get a chance to try a mainnet sync?
|
|
Apologies, I didn't get a chance to get to it last weekend. It is syncing now, so far so good - about 10% of the way through |
|
Syncs fine until chaintip, cli and fetch params work as expected |
RaghavSood
approved these changes
Dec 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty much a repackaging, because a lot has changed about
zcash in two major versions. Lots of libraries are no longer
necessary, and librustzcash is now part of the zcash package as
opposed to being a library supposed to be built seperately.
The whole thing is a buildRustPackage because that's easier than
trying to emulate buildRustPackage's dependency setup behaviour inside
a normal mkDerivation. So that the normal zcash build process is
followed, the actual configuring and building uses the normal stdenv
behaviour.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)