Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sfeed: init at 0.9.20 #107173

Merged
merged 2 commits into from Jan 22, 2021
Merged

sfeed: init at 0.9.20 #107173

merged 2 commits into from Jan 22, 2021

Conversation

matthiasbeyer
Copy link
Contributor

Motivation for this change

Closes #105090

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC @humaidq for testing

@fabaff
Copy link
Member

fabaff commented Dec 24, 2020

Result of nixpkgs-review pr 107173 run on x86_64-linux 1

1 package built:
  • sfeed

@matthiasbeyer matthiasbeyer force-pushed the init-sfeed branch 2 times, most recently from 6b2f527 to 0dcd56b Compare December 24, 2020 09:14
@iblech
Copy link
Contributor

iblech commented Jan 10, 2021

I confirm that the package works here, thank you @matthiasbeyer for your work and thank you @fabaff for the review! Can this be merged?

@matthiasbeyer
sfeed: init at 0.9.20
1a3d1bf 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
Update pkgs/tools/misc/sfeed/default.nix
7a8f5d0 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000 SuperSandro2000 merged commit e3b4a6c into NixOS:master Jan 22, 2021
@matthiasbeyer matthiasbeyer deleted the init-sfeed branch January 22, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packaging request: sfeed
4 participants
@matthiasbeyer @fabaff @iblech @SuperSandro2000