Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel-buildtools: 3.3.0 -> 3.5.0 #107177

Merged
merged 1 commit into from Dec 20, 2020
Merged

bazel-buildtools: 3.3.0 -> 3.5.0 #107177

merged 1 commit into from Dec 20, 2020

Conversation

avdv
Copy link
Member

@avdv avdv commented Dec 18, 2020 •
edited

Motivation for this change

New upstream release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

uri-canva
uri-canva approved these changes Dec 20, 2020
View reviewed changes
Copy link
Contributor

@uri-canva uri-canva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on macOS, looks good.

@marsam marsam merged commit d63cc95 into NixOS:master Dec 20, 2020
@avdv avdv deleted the bazel-buildtools_3.5.0 branch December 21, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uri-canva uri-canva uri-canva approved these changes

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@marsam marsam Awaiting requested review from marsam

@elasticdog elasticdog Awaiting requested review from elasticdog

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avdv @uri-canva @marsam