Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tageditor: init at 3.3.10, tagparser: init at 9.4.0 #107167

Merged
merged 2 commits into from Feb 2, 2021
Merged

tageditor: init at 3.3.10, tagparser: init at 9.4.0 #107167

merged 2 commits into from Feb 2, 2021

Conversation

matthiasbeyer
Copy link
Contributor

Motivation for this change

Closes #107006

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC @luxferresum for testing.

@taku0
Copy link
Contributor

taku0 commented Jan 31, 2021

Please rebase on master.

@matthiasbeyer matthiasbeyer changed the title Init tageditor tageditor: init at 3.3.10, tagparser: init at 9.4.0 Jan 31, 2021
@matthiasbeyer
Copy link
Contributor Author

Done

@taku0
Copy link
Contributor

taku0 commented Jan 31, 2021

It runs fine.

Please replace stdenv.lib with pkgs.lib.

Warning: stdenv.lib is deprecated and will be removed in the next release. Please use pkgs.lib instead. For more information see #108938

@matthiasbeyer
Copy link
Contributor Author

Done. If you approve, I'll squash.

taku0
taku0 approved these changes Jan 31, 2021
View reviewed changes
Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash.

@taku0
Copy link
Contributor

taku0 commented Feb 1, 2021

Waiting for ofborg...

@matthiasbeyer
tagparser: init at 9.4.0
aeab74d 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer
tageditor: init at 3.3.10
ab1f4bc 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@taku0
Copy link
Contributor

taku0 commented Feb 2, 2021

The pending check is the tests on x86_64-darwin while this package is Linux only. Merging.

@taku0 taku0 merged commit 4ceb20b into NixOS:master Feb 2, 2021
@matthiasbeyer matthiasbeyer deleted the init-tageditor branch February 2, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taku0 taku0 taku0 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag Editor
3 participants
@matthiasbeyer @taku0 @SuperSandro2000