cjson: init at 1.7.14 #107169
Merged
cjson: init at 1.7.14 #107169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabaff
reviewed
Dec 18, 2020
| meta = with stdenv.lib; { | ||
| homepage = "https://github.com/DaveGamble/cJSON"; | ||
| description = "Ultralightweight JSON parser in ANSI C "; | ||
| license = licenses.mit; |
There was a problem hiding this comment.
A part of the test suite is licensed under ASL 2.0.
There was a problem hiding this comment.
How to have multiple licenses in a package in nixpkgs?
There was a problem hiding this comment.
license = with licenses; [ mit asl20 ];
fabaff
reviewed
Dec 18, 2020
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = "https://github.com/DaveGamble/cJSON"; | ||
| description = "Ultralightweight JSON parser in ANSI C "; |
There was a problem hiding this comment.
Suggested change
| description = "Ultralightweight JSON parser in ANSI C "; | |
| description = "Ultralightweight JSON parser in ANSI C"; |
|
Result of 1 package built:
|
matthiasbeyer
force-pushed
the
init-cjson
branch
from
78a6a0b
to
069df6e
Compare
|
squashed. |
SuperSandro2000
requested changes
Jan 18, 2021
matthiasbeyer
force-pushed
the
init-cjson
branch
from
d257b16
to
ac50b48
Compare
|
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package failed to build and are new build failure:
|
matthiasbeyer
force-pushed
the
init-cjson
branch
from
0a9f616
to
cdbab28
Compare
prusnak
requested changes
Feb 1, 2021
|
Updated.
|
|
Please squash the fixup commit |
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
matthiasbeyer
force-pushed
the
init-cjson
branch
from
32a0eb6
to
5c33074
Compare
|
On 01-02-2021 09:07:28, Pavol Rusnak wrote:
Please squash the fixup commit
Done.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Closes #107161
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)CC @fabaff for testing