miniflux: remove adminCredentialsFile option #107180
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
about 6 months ago, upstream added the ability to load these variables from a file directly, via
ADMIN_USERNAME_FILE
andADMIN_PASSWORD_FILE
. This feature is included in the version in nixpkgs,2.0.23
.Therefore, we don't need the adminCredentialsFile option as it's now redundant. It seems like behavior isn't well defined if both the direct and as-file variables are set, so I've added some janky logic to not set a default if the other is set (though I've tested all 3 possible input states and it seems to work as expected).
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)