Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bashup-events: init at it's-complicated #107182

Merged
merged 1 commit into from Jan 18, 2021
Merged

bashup-events: init at it's-complicated #107182

merged 1 commit into from Jan 18, 2021

Conversation

abathur
Copy link
Member

@abathur abathur commented Dec 19, 2020 •
edited

Motivation for this change

  1. Add bashup.events, a Bash event/callback/promise library.

    • I've found the abstractions it provides make it easier to build and interface modular shell libraries.
    • Here's an example of how the package for a shell script/program/library that needs to source this can use it as an input.)
  2. Introduce the nixiverse to its new Bash/shell-packaging superpower that landed in resholve: init at 0.4.0 #85827

    champagne

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution sourcing of all binary files scripts (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Other notes
  • The library isn't versioned, per-se. It has two variants (one for Bash 3.2+, and one for 4.4+) that the author considers current/maintained. I'm not really sure how to handle this, so I just took a stab at it. :) You can see the issue I opened to ask about this at Thoughts on versioning? bashup/events#3.

@abathur abathur mentioned this pull request Dec 20, 2020
Merged
10 tasks
@abathur abathur marked this pull request as ready for review January 7, 2021 03:08
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107182 run on x86_64-linux 1

2 packages built:
  • bashup-events32
  • bashup-events44

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107182 run on x86_64-linux 1

2 packages built:
  • bashup-events32
  • bashup-events44

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107182 run on x86_64-darwin 1

2 packages built:
  • bashup-events32
  • bashup-events44

SuperSandro2000
SuperSandro2000 approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a squash and we can merge it

@abathur
Copy link
Member Author

abathur commented Jan 8, 2021

@SuperSandro2000 squashed and force-pushed.

Aside, in case it adds even more velocity to the sandro train: I gather the dropdown next to the Merge pull request button has a merge-and-squash option. (I have yet to see it myself; none of my repos have an open, mergeable commit.)

@SuperSandro2000
Copy link
Member

Aside, in case it adds even more velocity to the sandro train: I gather the dropdown next to the Merge pull request button has a merge-and-squash option. (I have yet to see it myself; none of my repos have an open, mergeable commit.)

The problem with that is that I need to remember it for this PR which I don't see myself doing.

@SuperSandro2000
Copy link
Member

I wouldn't mind if someone else could also take a look.

@abathur
Copy link
Member Author

abathur commented Jan 10, 2021

The problem with that is that I need to remember it for this PR which I don't see myself doing.

I wouldn't mind if someone else could also take a look.

I think I just misread you as saying something more like, "if this were already squashed, I would merge it now" :)

@abathur
Copy link
Member Author

abathur commented Jan 10, 2021

I force-pushed to change stdenv.lib -> lib per 108938 (on the topic of deprecating stdenv.lib use in nixpkgs; intentionally incomplete mention to avoid cluttering that issue).

fresh nixpkgs-review:

$ nix run nixpkgs#nixpkgs-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /Users/abathur/.cache/nixpkgs-review/rev-8a4a6b631d135f558fd99ff1cdf4a31e46b3150a/nixpkgs 51894963cbdc41f0cd8f571b7bcf79437d940355
Preparing worktree (detached HEAD 51894963cbd)
Updating files: 100% (23867/23867), done.
HEAD is now at 51894963cbd Merge pull request #89775 from numinit/update-androidenv
$ nix-env -f /Users/abathur/.cache/nixpkgs-review/rev-8a4a6b631d135f558fd99ff1cdf4a31e46b3150a/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 8a4a6b631d135f558fd99ff1cdf4a31e46b3150a
Auto-merging pkgs/top-level/all-packages.nix
Automatic merge went well; stopped before committing as requested
$ nix-env -f /Users/abathur/.cache/nixpkgs-review/rev-8a4a6b631d135f558fd99ff1cdf4a31e46b3150a/nixpkgs -qaP --xml --out-path --show-trace --meta
2 packages added:
bashup-events32 (init at 2019-07-27) bashup-events44 (init at 2020-04-04)

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /Users/abathur/.cache/nixpkgs-review/rev-8a4a6b631d135f558fd99ff1cdf4a31e46b3150a/build.nix
2 packages built:
bashup-events32 bashup-events44

@abathur
Copy link
Member Author

abathur commented Jan 18, 2021

Force-push is just to squash. No new changes.

@SuperSandro2000 SuperSandro2000 merged commit c0ef7fc into NixOS:master Jan 18, 2021
@abathur abathur deleted the init_bashup_events branch March 4, 2021 19:01
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/brainstorming-for-rfc-pname-and-version/12873/20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abathur @SuperSandro2000 @nixos-discourse @zimbatm