Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sudo: 1.9.4 -> 1.9.4p1 #107166

Merged
merged 1 commit into from Dec 20, 2020
Merged

sudo: 1.9.4 -> 1.9.4p1 #107166

merged 1 commit into from Dec 20, 2020

Conversation

mohe2015
Copy link
Contributor

@mohe2015 mohe2015 commented Dec 18, 2020 •
edited

Motivation for this change

https://www.sudo.ws/stable.html#1.9.4p1 especially segmentation fault when unknown username is given

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edolstra and delroth December 20, 2020 01:21
@NeQuissimus NeQuissimus merged commit 9ff582a into NixOS:master Dec 20, 2020
@mohe2015 mohe2015 deleted the update-sudo branch December 20, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth delroth approved these changes

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mohe2015 @delroth @NeQuissimus