pyoxisizer: init at 0.10.3 #107175
Closed
pyoxisizer: init at 0.10.3 #107175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emantor
suggested changes
Dec 29, 2020
|
Thanks for tagging me. I don’t think `pyoxidizer build` will work on Darwin without pulling in the SDK - the runtime depends on several of Apple’s frameworks.
Sent with [ProtonMail](https://protonmail.com) Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
…On Saturday, 19 December 2020 00:29, Matthias Beyer ***@***.***> wrote:
Motivation for this change
Closes [#104218](#104218)
Things done
- Tested using sandboxing ([nix.useSandbox](https://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option sandbox in [nix.conf](https://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux)
- Built on platform(s)
- NixOS
- macOS
- other Linux distributions
- Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
- Tested execution of all binary files (usually in ./result/bin/)
- Determined the impact on package closure size (by running nix path-info -S before and after)
- Ensured that relevant documentation is up to date
- Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
CC ***@***.***(https://github.com/layday) for testing
Metadata for this package is missing as I don't know what platforms it works on and also because I don't want to take maintainership. Maybe ***@***.***(https://github.com/layday) would like to be maintainer for this?
---------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
#107175
Commit Summary
- pyoxisizer: init at 0.10.3
File Changes
- A [pkgs/development/tools/pyoxidizer/default.nix](https://github.com/NixOS/nixpkgs/pull/107175/files#diff-483b88c313e351862c07a8df21cef09a2ca3ad7022c0874fc609ed21de6c9cdb) (24)
- M [pkgs/top-level/all-packages.nix](https://github.com/NixOS/nixpkgs/pull/107175/files#diff-ab5748dc9567516fefba8344056b51ec1866adeace380f46e58a7af3d619ea22) (2)
Patch Links:
- https://github.com/NixOS/nixpkgs/pull/107175.patch
- https://github.com/NixOS/nixpkgs/pull/107175.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#107175), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AHNRFWE6FSO5TBHSI5BIYODSVPJTZANCNFSM4VBYGP7Q).
|
Feel free to send me patches for this, I don't have the infrastructure to test on Apple. |
|
I would not be comfortable taking on maintenance of a package in a language I am unfamiliar with.
Sent with [ProtonMail](https://protonmail.com) Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
…On Tuesday, 29 December 2020 12:23, Matthias Beyer ***@***.***> wrote:
***@***.***(https://github.com/layday) feel also free to send me a patch taking maintainership for this. I don't want to be maintainer, I just wanted to help to close [#104218](#104218)
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#107175 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AHNRFWDY5EL5KPLYLGA5P63SXGU3BANCNFSM4VBYGP7Q).
|
SuperSandro2000
requested changes
Jan 17, 2021
| @@ -0,0 +1,30 @@ | |||
| { stdenv | |||
| , pkgconfig | |||
| , python38 | |||
There was a problem hiding this comment.
Do we need to pin python38 here?
There was a problem hiding this comment.
Please rather use python3.
matthiasbeyer
force-pushed
the
init-pyoxidizer
branch
from
f2a376e
to
25ae108
Compare
|
|
||
| cargoSha256 = "14k81n56w29fdwm1bwbsmb3p7nawjbvfrqg2p74a0bz33hq5iby3"; | ||
| depsBuildBuild = [ openssl pkg-config python38 ]; | ||
| doCheck = false; |
There was a problem hiding this comment.
Please add a comment why you disabled tests.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
matthiasbeyer
force-pushed
the
init-pyoxidizer
branch
from
25ae108
to
be9e01e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Closes #104218
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)CC @layday for testing
Metadata for this package is missing as I don't know what platforms it works on and also because I don't want to take maintainership. Maybe @layday would like to be maintainer for this?