nixos/moinmoin: fix module by switching to eventlet worker #108045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service was failing with: gunicorn[2192104]: [2020-12-31 13:35:28 +0000] [2192104] [ERROR] Exception in worker process gunicorn[2192104]: Traceback (most recent call last): gunicorn[2192104]: File "/nix/store/jmc14qf1sfnlhw27xyyj862ghkmdkj5a-python2.7-gunicorn-19.10.0/lib/python2.7/site-packages/gunicorn/arbiter.py", line 586, in spawn_worker gunicorn[2192104]: worker.init_process() gunicorn[2192104]: File "/nix/store/jmc14qf1sfnlhw27xyyj862ghkmdkj5a-python2.7-gunicorn-19.10.0/lib/python2.7/site-packages/gunicorn/workers/ggevent.py", line 196, in init_process gunicorn[2192104]: self.patch() gunicorn[2192104]: File "/nix/store/jmc14qf1sfnlhw27xyyj862ghkmdkj5a-python2.7-gunicorn-19.10.0/lib/python2.7/site-packages/gunicorn/workers/ggevent.py", line 65, in patch gunicorn[2192104]: monkey.patch_all(subprocess=True) gunicorn[2192104]: File "/nix/store/fysf67w3i8iv1hfvp536nl8jbzqyk1s7-python-2.7.18-env/lib/python2.7/site-packages/gevent/monkey.py", line 1160, in patch_all gunicorn[2192104]: from gevent import events gunicorn[2192104]: File "/nix/store/fysf67w3i8iv1hfvp536nl8jbzqyk1s7-python-2.7.18-env/lib/python2.7/site-packages/gevent/events.py", line 67, in <module> gunicorn[2192104]: from zope.interface import Interface gunicorn[2192104]: ImportError: No module named zope.interface
otavio
approved these changes
Dec 31, 2020
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
this should probably update to python3 instead zope implements a native namespace so there's not conflict in python3, but this isn't a feature in python2 |
|
Unfortunately moinmoin probably won't be ported to python3:( http://moinmo.in/Python3 |
|
@ofborg test moinmoin |
|
Thanks for the fix! It seems that 20.09 is also effected by this. Could you backport this PR? |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The service (and consequently
nixosTests.moinmoin) was failing with:The
geventpackage does depend onzope_interfacehowever. I wasn't able to figure out why exactly cannot the module be imported and decided to switch to differentgunicornbackend instead.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)