Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.bisect_ppx: 1.4.0 → 2.5.0 #108026

Merged
merged 2 commits into from Jan 6, 2021
Merged

ocamlPackages.bisect_ppx: 1.4.0 → 2.5.0 #108026

merged 2 commits into from Jan 6, 2021

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Dec 31, 2020

Motivation for this change

Fixes & improvements: https://github.com/aantron/bisect_ppx/releases

The plugin for ocamlbuild is no longer part of the source distribution and no longer maintained.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member

Result of nixpkgs-review pr 108026 1

4 packages built:
  • ocamlPackages.arp
  • ocamlPackages.bisect_ppx
  • ocamlPackages.mirage-nat
  • ocamlPackages.tcpip

sternenseemann
sternenseemann approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vbgl vbgl merged commit ccc474d into NixOS:master Jan 6, 2021
@vbgl vbgl deleted the ocaml-bisect_ppx-2.5.0 branch January 6, 2021 06:35
@vbgl vbgl mentioned this pull request Jan 7, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: clean-up 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @sternenseemann