Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

printrun: unstable-2015-03-10 -> 1.6.0 #107986

Merged
merged 1 commit into from Jan 1, 2021
Merged

printrun: unstable-2015-03-10 -> 1.6.0 #107986

merged 1 commit into from Jan 1, 2021

Conversation

leenaars
Copy link
Contributor

Motivation for this change

From unstable git to latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member

prusnak commented Dec 30, 2020 •
edited

Readme says Python 3 is required. Will you change python27Packages to python3Packages and check everything works as expected?

@thiagokokada
Copy link
Contributor

thiagokokada commented Dec 30, 2020 •
edited

@prusnak I think Python 3 version is the current master branch (unreleased, future 2.x version), while this bump is related to 1.x branch that still uses Python 2.

@thiagokokada
Copy link
Contributor

Tested it and works (this package mess up with nixpkgs env so I can't post build results).

BTW, all binaries have .py extension, ideally this should be renamed, but it is better to do it in another PR.

@leenaars
Copy link
Contributor Author

I think with the package being around for a number of years with .py names, renaming at this stage might break people's workflow. Don't know what the best practice would be, inclined to leave as is until the next major release (likely on python3).

prusnak
prusnak requested changes Dec 30, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to:
printrun: unstable-2015-03-10 -> 1.6.0

@leenaars leenaars changed the title printrun: unstable -> 1.6.0 printrun: unstable-2015-03-10 -> 1.6.0 Jan 1, 2021
@leenaars leenaars requested a review from prusnak January 1, 2021 08:33
prusnak
prusnak requested changes Jan 1, 2021
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have not changed the commit message, only the title of this pull request on GitHub

What you want to run is

git commit -a --amend + edit the commit message

and then

git push --force

@thiagokokada
Copy link
Contributor

The commit message is still wrong:
printrun -> unstable-2015-03-10 -> 1.6.0

Should be:
printrun: unstable-2015-03-10 -> 1.6.0

@prusnak prusnak merged commit e2829e2 into NixOS:master Jan 1, 2021
@leenaars leenaars deleted the printrun branch January 6, 2021 14:09
@alexfmpe
Copy link
Member

Note that 1.6.0 is over 3 years old hence #90272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak requested changes

@thiagokokada thiagokokada thiagokokada approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leenaars @prusnak @thiagokokada @alexfmpe