Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfce.xfce4-namebar-plugin: fix build #107985

Merged
merged 1 commit into from Dec 30, 2020
Merged

xfce.xfce4-namebar-plugin: fix build #107985

merged 1 commit into from Dec 30, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 30, 2020 •
edited

Motivation for this change

noticed it was failing to build

  configure flags: --prefix=/nix/store/2hxlg20rqh6ksjj4k6amrk0bhg4mq0dz-xfce4-namebar-plugin-1.0.0 configure
  /nix/store/3af4czhg5b9vaawzdwfirlphgg9spxf7-hook/nix-support/setup-hook: line 22: python: command not found
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested review from romildo and prusnak and removed request for romildo December 30, 2020 19:50
@jonringer
Copy link
Contributor Author

arch failure is related to a dependency

@jonringer jonringer merged commit 572a864 into NixOS:staging-next Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

Assignees
No one assigned
Labels
6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @prusnak