Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new-session-manager: init at 1.4.0 #107997

Merged
merged 2 commits into from Jan 1, 2021
Merged

new-session-manager: init at 1.4.0 #107997

merged 2 commits into from Jan 1, 2021

Conversation

6AA4FD
Copy link
Contributor

@6AA4FD 6AA4FD commented Dec 30, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@6AA4FD 6AA4FD mentioned this pull request Dec 30, 2020
Open
13 tasks
SuperSandro2000
SuperSandro2000 requested changes Dec 31, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the package related commits together.

pkgs/applications/audio/new-session-manager/default.nix Outdated Show resolved Hide resolved
@6AA4FD
Copy link
Contributor Author

6AA4FD commented Dec 31, 2020

Please squash the package related commits together.

@SuperSandro2000 done!

@6AA4FD
Copy link
Contributor Author

6AA4FD commented Dec 31, 2020

@SuperSandro2000 done!

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107997 run on x86_64-linux 1

1 package built:
  • new-session-manager

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

new-session-manager.log:

`gpl3` is a deprecated license, check if project uses `gpl3Plus` or `gpl3Only` and change `meta.license` accordingly.

Near pkgs/applications/audio/new-session-manager/default.nix:24:5:

   |
24 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

@6AA4FD
Copy link
Contributor Author

6AA4FD commented Dec 31, 2020

@SuperSandro2000 done!

@SuperSandro2000
Copy link
Member

@6AA4FD Please fix the merge conflict.

@6AA4FD
Copy link
Contributor Author

6AA4FD commented Jan 1, 2021

@SuperSandro2000 done!

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107997 run on x86_64-linux 1

1 package built:
  • new-session-manager

@SuperSandro2000 SuperSandro2000 merged commit d974d7f into NixOS:master Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@siraben siraben siraben approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@6AA4FD @SuperSandro2000 @siraben