Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-cli: 2.16.0 -> 2.17.0, bump azure python packages #107996

Merged
merged 7 commits into from Dec 31, 2020
Merged

azure-cli: 2.16.0 -> 2.17.0, bump azure python packages #107996

merged 7 commits into from Dec 31, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 30, 2020 •
edited

Motivation for this change

closes: #107905

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/107996

13 packages built:
azure-cli python37Packages.azure-mgmt-cdn python37Packages.azure-mgmt-databoxedge python37Packages.azure-mgmt-loganalytics python37Packages.azure-mgmt-recoveryservices python37Packages.azure-synapse-artifacts python37Packages.azure-synapse-spark python38Packages.azure-mgmt-cdn python38Packages.azure-mgmt-databoxedge python38Packages.azure-mgmt-loganalytics python38Packages.azure-mgmt-recoveryservices python38Packages.azure-synapse-artifacts python38Packages.azure-synapse-spark

@ofborg ofborg bot requested a review from mwilsoncoding December 30, 2020 22:44
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107996 run on x86_64-darwin 1

19 packages built:
  • azure-cli
  • python37Packages.azure-mgmt-cdn
  • python37Packages.azure-mgmt-databoxedge
  • python37Packages.azure-mgmt-loganalytics
  • python37Packages.azure-mgmt-recoveryservices
  • python37Packages.azure-synapse-artifacts
  • python37Packages.azure-synapse-spark
  • python38Packages.azure-mgmt-cdn
  • python38Packages.azure-mgmt-databoxedge
  • python38Packages.azure-mgmt-loganalytics
  • python38Packages.azure-mgmt-recoveryservices
  • python38Packages.azure-synapse-artifacts
  • python38Packages.azure-synapse-spark
  • python39Packages.azure-mgmt-cdn
  • python39Packages.azure-mgmt-databoxedge
  • python39Packages.azure-mgmt-loganalytics
  • python39Packages.azure-mgmt-recoveryservices
  • python39Packages.azure-synapse-artifacts
  • python39Packages.azure-synapse-spark

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107996 run on x86_64-linux 1

13 packages built:
  • azure-cli
  • python37Packages.azure-mgmt-cdn
  • python37Packages.azure-mgmt-databoxedge
  • python37Packages.azure-mgmt-loganalytics
  • python37Packages.azure-mgmt-recoveryservices
  • python37Packages.azure-synapse-artifacts
  • python37Packages.azure-synapse-spark
  • python38Packages.azure-mgmt-cdn
  • python38Packages.azure-mgmt-databoxedge
  • python38Packages.azure-mgmt-loganalytics
  • python38Packages.azure-mgmt-recoveryservices
  • python38Packages.azure-synapse-artifacts
  • python38Packages.azure-synapse-spark

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.azure-synapse-artifacts.log:
Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

python37Packages.azure-synapse-spark.log:
Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

python38Packages.azure-synapse-artifacts.log:
Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

python38Packages.azure-synapse-spark.log:
Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@jonringer jonringer merged commit 476a33d into NixOS:master Dec 31, 2020
@jonringer jonringer deleted the bump-azure branch December 31, 2020 05:58
@marsam marsam mentioned this pull request Jan 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@mwilsoncoding mwilsoncoding Awaiting requested review from mwilsoncoding

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure-cli-2.6.0: out-of-date (2.17.0 is now available)
2 participants
@jonringer @SuperSandro2000