Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kaldi: init at 2020-12-26 #108027

Merged
merged 1 commit into from Jan 1, 2021
Merged

kaldi: init at 2020-12-26 #108027

merged 1 commit into from Jan 1, 2021

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 31, 2020

State-of-the-art speech-to-text engine - used in rhasspy

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from mweinelt December 31, 2020 09:18
@Mic92
Copy link
Member Author

Mic92 commented Dec 31, 2020

I am using this package for 1-2 years.

pkgs/tools/audio/kaldi/default.nix Outdated Show resolved Hide resolved
pkgs/tools/audio/kaldi/default.nix Show resolved Hide resolved
pkgs/tools/audio/kaldi/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108027 run on x86_64-darwin 1

1 package failed to build:
  • kaldi
CMake Error at /nix/store/fhp2mjmbhkjsn3czhd0y8fphs83xxnq1-cmake-3.19.1/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:218 (message):
  Could NOT find BLAS (missing: BLAS_LIBRARIES)
Call Stack (most recent call first):
  /nix/store/fhp2mjmbhkjsn3czhd0y8fphs83xxnq1-cmake-3.19.1/share/cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:577 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindBLAS.cmake:892 (find_package_handle_standard_args)
  CMakeLists.txt:89 (find_package)


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-kaldi-2020-12-26.drv-0/source/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-kaldi-2020-12-26.drv-0/source/build/CMakeFiles/CMakeError.log".

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108027 run on x86_64-linux 1

1 package built:
  • kaldi

State-of-the-art speech-to-text engine - used in rhasspy

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@Mic92
Copy link
Member Author

Mic92 commented Jan 1, 2021

Now it only builds for Linux. It probably would build for macOS too, but it requires some blas fixes.

@mweinelt mweinelt merged commit 5bcc263 into NixOS:master Jan 1, 2021
@Mic92 Mic92 deleted the kaldi branch January 1, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants