Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2020.12.29 -> 2020.12.31 #107998

Merged
merged 1 commit into from Dec 31, 2020
Merged

youtube-dl: 2020.12.29 -> 2020.12.31 #107998

merged 1 commit into from Dec 31, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Dec 30, 2020

https://github.com/ytdl-org/youtube-dl/releases/tag/2020.12.31

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq zowoq added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 30, 2020
thiagokokada
thiagokokada approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not running nixpkgs-review though since this cause a long rebuild.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/313

@nh2
Copy link
Contributor

nh2 commented Dec 31, 2020

Works for me on

  • NixOS

@nh2 nh2 merged commit 45a219e into NixOS:master Dec 31, 2020
@zowoq
Copy link
Contributor Author

zowoq commented Dec 31, 2020

20.09: 6c6ab8c

@zowoq zowoq deleted the ytdl branch December 31, 2020 01:15
@zowoq zowoq added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

@Enzime Enzime Awaiting requested review from Enzime

@Phreedom Phreedom Awaiting requested review from Phreedom

@Ma27 Ma27 Awaiting requested review from Ma27

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zowoq @nixos-discourse @nh2 @thiagokokada