Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/prometheus: fix remote_{read,write} options #108067

Merged
merged 1 commit into from Jan 1, 2021

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Dec 31, 2020

Motivation for this change

Apparently some options are different between remote_read and remote_write.
Fixing this oversight.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this against the prometheus documentation, seems good now.
Just a question regarding consistency among the new options:

nixos/modules/services/monitoring/prometheus/default.nix Outdated Show resolved Hide resolved
nixos/modules/services/monitoring/prometheus/default.nix Outdated Show resolved Hide resolved
Fix and reorder options and use mkOpt for optional parameters,
according to official documentation.
@WilliButz WilliButz merged commit 15c7a0e into NixOS:master Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants