Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbeaver: 7.3.0 -> 7.3.1 #107332

Merged
merged 1 commit into from Dec 31, 2020
Merged

dbeaver: 7.3.0 -> 7.3.1 #107332

merged 1 commit into from Dec 31, 2020

Conversation

jojosch
Copy link
Member

@jojosch jojosch commented Dec 21, 2020

Motivation for this change

New upstream release https://dbeaver.io/2020/12/20/dbeaver-7-3-1/

The upstream archive now contains its own JRE installation, which must be removed for dbeaver to run. Otherwise, ./result/bin/dbeaver immediately terminates.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/mi9lbh3zpvbifw03b41x6gbg9amphv7n-dbeaver-ce-7.3.0	 1455757672
/nix/store/k843v61fw73wrh9iiwcd3prdyq31v832-dbeaver-ce-7.3.1	 1456190936

@WolfangAukang
Copy link
Contributor

WolfangAukang commented Dec 31, 2020 •
edited

Result of nixpkgs-review pr 107332 run on x86_64-linux 1

1 package built:
  • dbeaver

Working for me and code LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/315

@nh2 nh2 merged commit 7da8c44 into NixOS:master Dec 31, 2020
@jojosch jojosch deleted the dbeaver-7.3.1 branch December 31, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WolfangAukang WolfangAukang WolfangAukang approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jojosch @WolfangAukang @nixos-discourse @nh2