Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging-next] mesa: fix build on darwin #108015

Merged
merged 1 commit into from Dec 31, 2020
Merged

[staging-next] mesa: fix build on darwin #108015

merged 1 commit into from Dec 31, 2020

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Dec 31, 2020

Latest mesa requires macOS SDK 10.13 - this applies an upstream
patch for compatibility with 10.13

Applied on darwin only to avoid linux rebuilds in staging-next - left a
note that this can be done unconditionally as it has no effect on
non-darwin platforms, if this would be considered more robust.

cc @FRidh

Have not tested thoroughly beyond mesa itself - let me know if there are any dependees in particular I can check.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-burns
mesa: fix build on darwin
067b701 
Latest mesa requires macOS SDK 10.13 - this applies an upstream
patch for compatibility with 10.13

Applied on darwin only to avoid linux rebuilds in staging-next - left a
note that this can be done unconditionally as it has no effect on
non-darwin platforms, if this would be considered more robust.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 31, 2020
@ofborg ofborg bot requested review from primeos and vcunat December 31, 2020 03:19
@r-burns r-burns changed the title mesa: fix build on darwin [staging-next] mesa: fix build on darwin Dec 31, 2020
@FRidh FRidh merged commit 7115040 into NixOS:staging-next Dec 31, 2020
@r-burns r-burns deleted the mesa branch December 31, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos Awaiting requested review from primeos

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-burns @FRidh