Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hover: 0.43.0 -> 0.46.1 #108016

Merged
merged 1 commit into from Dec 31, 2020
Merged

hover: 0.43.0 -> 0.46.1 #108016

merged 1 commit into from Dec 31, 2020

Conversation

thiagokokada
Copy link
Contributor

Motivation for this change

Multiple new releases: https://github.com/go-flutter-desktop/hover/releases/tag/v0.46.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada
Copy link
Contributor Author

thiagokokada commented Dec 31, 2020 •
edited

Result of nixpkgs-review pr 108016 1

1 package built:
  • hover

Tested with a Flutter project, it builds and runs.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/418

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108016 run on x86_64-linux 1

1 package built:
  • hover

@prusnak prusnak merged commit 93f3602 into NixOS:master Dec 31, 2020
@thiagokokada thiagokokada deleted the bump-hover branch December 31, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@ericdallo ericdallo Awaiting requested review from ericdallo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thiagokokada @nixos-discourse @SuperSandro2000 @prusnak