Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/binfmt.nix: fix running commands in binfmt #108072

Merged
merged 1 commit into from Jan 20, 2021
Merged

nixos/binfmt.nix: fix running commands in binfmt #108072

merged 1 commit into from Jan 20, 2021

Conversation

matthewbauer
Copy link
Member

To allow arguments in binfmt, we need to put the command in a shell
script. This uses exec to run the binfmt interpreter.

Fixes #90683

@matthewbauer
nixos/binfmt.nix: fix running commands in binfmt
08135a3 
To allow arguments in binfmt, we need to put the command in a shell
script. This uses exec to run the binfmt interpreter.

Fixes NixOS#90683
@matthewbauer matthewbauer mentioned this pull request Dec 31, 2020
Closed
SuperSandro2000
SuperSandro2000 reviewed Jan 3, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

@matthewbauer matthewbauer merged commit da9fc7b into NixOS:master Jan 20, 2021
@mohe2015 mohe2015 mentioned this pull request Jan 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Activation script for binfmt fails
2 participants
@matthewbauer @SuperSandro2000