Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt512: 5.12.7 -> 5.12.9 #107483

Merged
merged 6 commits into from Dec 30, 2020
Merged

qt512: 5.12.7 -> 5.12.9 #107483

merged 6 commits into from Dec 30, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Dec 23, 2020 •
edited

Motivation for this change

Update + add a few explanations in places were 5.12 is pinned (#104474) and unpin 1 package (sdrangel) from using qt5.12.

Things done

Checked that the following build:

  • qtbase
  • sdrangel builds and works.
  • qtdeclarative
  • qtwayland
  • qtquickcontrols
  • qtsvg
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from alkeryn December 23, 2020 17:45
SuperSandro2000
SuperSandro2000 reviewed Dec 23, 2020
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
prusnak
prusnak approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested, changes look OK

@doronbehar doronbehar mentioned this pull request Dec 23, 2020
Open
9 tasks
@ttuegel ttuegel added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 30, 2020
@ttuegel ttuegel merged commit 355df33 into NixOS:master Dec 30, 2020
@ttuegel
Copy link
Member

ttuegel commented Dec 30, 2020

Thanks!

ttuegel added a commit to ttuegel/nixpkgs that referenced this pull request Dec 31, 2020
@ttuegel
Merge pull request NixOS#107483 from doronbehar/pkg/qt512
39aa07b 
qt512: 5.12.7 -> 5.12.9
(cherry picked from commit 355df33)
@collares
Copy link
Member

collares commented Dec 31, 2020 •
edited

I think this caused Hydra failures: https://hydra.nixos.org/build/134031567/nixlog/1/tail (cf. #74911)

@doronbehar
Copy link
Contributor Author

doronbehar commented Dec 31, 2020 via email

@prusnak prusnak mentioned this pull request Jan 1, 2021
Merged
10 tasks
@ttuegel ttuegel mentioned this pull request Jan 1, 2021
Merged
10 tasks
@doronbehar doronbehar deleted the pkg/qt512 branch March 2, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@prusnak prusnak prusnak approved these changes

@alkeryn alkeryn Awaiting requested review from alkeryn

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@doronbehar @ttuegel @collares @prusnak @SuperSandro2000