Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.delta: 0.4.5 -> 0.5.0 #108006

Merged
merged 1 commit into from Dec 31, 2020
Merged

gitAndTools.delta: 0.4.5 -> 0.5.0 #108006

merged 1 commit into from Dec 31, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Dec 31, 2020

https://github.com/dandavison/delta/releases/tag/0.5.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq zowoq changed the title delta: 0.4.5 -> 0.5.0 gitAndTools.delta: 0.4.5 -> 0.5.0 Dec 31, 2020
@ofborg ofborg bot requested review from marsam and Ma27 December 31, 2020 01:24
@lovesegfault
Copy link
Member

Result of nixpkgs-review pr 108006 run on x86_64-linux 1

2 packages built:
  • bat-extras.batdiff
  • gitAndTools.delta

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108006 run on x86_64-linux 1

2 packages built:
  • bat-extras.batdiff
  • gitAndTools.delta

@lovesegfault lovesegfault merged commit 4e825a8 into NixOS:master Dec 31, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108006 run on x86_64-darwin 1

2 packages failed to build:
  • bat-extras.batdiff
  • gitAndTools.delta

delta:

failures:

---- main_tests::test_diff_empty_vs_non_empty_file stdout ----
thread 'main_tests::test_diff_empty_vs_non_empty_file' panicked at 'assertion failed: `(left == right)`
  left: `2`,
 right: `1`', src/main.rs:533:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- main_tests::test_diff_same_non_empty_file stdout ----
thread 'main_tests::test_diff_same_non_empty_file' panicked at 'assertion failed: `(left == right)`
  left: `2`,
 right: `0`', src/main.rs:539:13

---- main_tests::test_diff_two_non_empty_files stdout ----
thread 'main_tests::test_diff_two_non_empty_files' panicked at 'assertion failed: `(left == right)`
  left: `2`,
 right: `1`', src/main.rs:533:13


failures:
    main_tests::test_diff_empty_vs_non_empty_file
    main_tests::test_diff_same_non_empty_file
    main_tests::test_diff_two_non_empty_files

test result: FAILED. 208 passed; 3 failed; 6 ignored; 0 measured; 0 filtered out

@zowoq zowoq deleted the delta branch December 31, 2020 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault approved these changes

@marsam marsam Awaiting requested review from marsam

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @lovesegfault @SuperSandro2000