Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcrypt: patch to include stdlib.h instead of malloc.h to build on darwin #108009

Merged
merged 2 commits into from Jan 8, 2021
Merged

mcrypt: patch to include stdlib.h instead of malloc.h to build on darwin #108009

merged 2 commits into from Jan 8, 2021

Conversation

nima2007
Copy link
Contributor

@nima2007 nima2007 commented Dec 31, 2020 •
edited

Motivation for this change

Package does not compile on macOS.
malloc.h is non-portable and deprecated. macOS doesn't work with it.
The mcrypt dev site is pretty stale with a ticket about this opened in 2009 (https://sourceforge.net/p/mcrypt/bugs/36/)

Things done

@nima2007
mcrypt: patch to include stdlib.h instead of malloc.h to build on darwin
3bf056a 
malloc.h is deprecated and the package does not compile on macOS due to this.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 31, 2020
@nima2007
Copy link
Contributor Author

Result of nixpkgs-review pr 108009 run on x86_64-linux 1

1 package built:
  • mcrypt

@ofborg ofborg bot requested a review from qknight December 31, 2020 01:29
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108009 run on x86_64-linux 1

1 package built:
  • mcrypt

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108009 run on x86_64-linux 1

1 package built:
  • mcrypt

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

@nima2007
mcrypt: update license to GPL 3
dcc390f 
This release 2.6.8 is using GNU GPL V3, not V2
@nima2007
Copy link
Contributor Author

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Updated license to GPL version 3 based on the file "COPYING" in source code root

@nima2007 nima2007 marked this pull request as ready for review December 31, 2020 03:27
@prusnak prusnak merged commit 922b041 into NixOS:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@qknight qknight Awaiting requested review from qknight

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nima2007 @SuperSandro2000 @prusnak