Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave: test rpath in installCheck #108057

Merged
merged 1 commit into from Jan 1, 2021
Merged

brave: test rpath in installCheck #108057

merged 1 commit into from Jan 1, 2021

Conversation

bbjubjub2494
Copy link
Member

Motivation for this change

This check helps with making sure that we provide all the required
shared libraries to brave. If something is missing, the command will get
ENOENT, otherwise it should terminate normally.

#108029 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@otavio
Copy link
Contributor

otavio commented Dec 31, 2020

LGTM.

@ofborg ofborg bot requested review from nasirhm, rht and uskudnik December 31, 2020 17:02
nasirhm
nasirhm approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@nasirhm nasirhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straight forward, LGTM, Thank you working on it @lourkeur :D 👍

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108057 run on x86_64-linux 1

1 package built:
  • brave

@bbjubjub2494 @danieldk
brave: test rpath in installCheck
051389e 
This check helps with making sure that we provide all the required
shared libraries to brave. If something is missing, the command will get
ENOENT, otherwise it should terminate normally.
@ofborg ofborg bot requested a review from nasirhm January 1, 2021 12:41
@danieldk danieldk merged commit 815bfe3 into NixOS:master Jan 1, 2021
@danieldk
Copy link
Contributor

danieldk commented Jan 1, 2021

Thanks! Rebased and merged.

@bbjubjub2494 bbjubjub2494 deleted the brave-installCheck branch January 10, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otavio otavio otavio approved these changes

@danieldk danieldk Awaiting requested review from danieldk

@rht rht Awaiting requested review from rht

@uskudnik uskudnik Awaiting requested review from uskudnik

@nasirhm nasirhm Awaiting requested review from nasirhm

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bbjubjub2494 @otavio @SuperSandro2000 @danieldk @nasirhm