Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxkbcommon: 0.10.0 -> 1.0.3 #108004

Merged
merged 1 commit into from Jan 9, 2021
Merged

Conversation

colemickens
Copy link
Member

@colemickens colemickens commented Dec 31, 2020

Motivation for this change

This updates libxkbcommon from 0.10.0 to latest stable, 1.0.3.

Fixes #108003.

This is currently a draft since I haven't run nixpkgs-review since I'm expecting a huge rebuild.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens
Copy link
Member Author

colemickens commented Dec 31, 2020

cc: @jtojnar @worldofpeace since you reviewed/merged last time. Thanks ❤️ ! (er, a bit pre-emptive, I could've waited until my nixpkgs-review finished...)

@jtojnar
Copy link
Contributor

jtojnar commented Dec 31, 2020

In the NEWS, the following items caught my attention:

@ttuegel
Copy link
Member

ttuegel commented Dec 31, 2020

Please rebase this against the staging branch due to the number of rebuilds.

@primeos primeos mentioned this pull request Jan 2, 2021
10 tasks
@SuperSandro2000
Copy link
Member

/rebase-staging

@github-actions github-actions bot changed the base branch from master to staging January 5, 2021 02:13
@AndersonTorres
Copy link
Member

@jtojnar my ten cents:

  • “Add libxkbregistry as configure-time optional library.” Is this included in the package? Can it be built separately?

Well, I think it is a case for multiple outputs.

I think it can be both. The upstream's rationale is this:

  • Add /etc/xkb as extra lookup path for system data files.

    This completes the usual triplet of configuration locations available for
    most processes:

    • vendor-provided data files in /usr/share/X11/xkb
    • system-specific data files in /etc/xkb
    • user-specific data files in $XDG_CONFIG_HOME/xkb

    The default lookup order user, system, vendor, just like everything else
    that uses these conventions.

  • “Add an xkbcli command-line utility.” Does the utility work without changes or is some wrapping required?

Wait for the worst. Certainly it will seek configurations in the three paths above.

@colemickens
Copy link
Member Author

Please don't let this PR stop someone else from picking it up. I'd drafted it thinking it would just be a version bump. It could be a while before I have time to really focus on this, sorry.

@primeos primeos self-assigned this Jan 9, 2021
@primeos primeos marked this pull request as ready for review January 9, 2021 11:59
@primeos
Copy link
Member

primeos commented Jan 9, 2021

Please don't let this PR stop someone else from picking it up. I'd drafted it thinking it would just be a version bump. It could be a while before I have time to really focus on this, sorry.

Ok, thanks for the update, I'll try to take care of the rest.

“Add libxkbregistry as configure-time optional library.” Is this included in the package? Can it be built separately?

It is new and optional so I'd disable it for now. Installing it into a separate output seems like a nice idea but I think we should add a Meson option to install it into a different prefix first (after this PR).

“The tests no longer rely on bash, only Python” Is it possible that this fixes the tests?

Still fail, I'll look into that later. The're enabled now.

TODO (I'll try to test this on my old desktop in a few hours):

Update: Fixed now (was ${libxkbcommon}/etc).

  • “Add an xkbcli command-line utility.” Does the utility work without changes or is some wrapping required?

Update: Yes, it works (though I didn't test all subcommands).

Relevant changes:
- Add libxml2 as a required dependency
- Disable libxkbregistry for now (a new but optional library -> install
  into a dedicated output when we need it)
- Set the lookup path for system data files to /etc/xkb
- Enable the tests
- Extend the meta attributes and minor code style changes

Co-Authored-By: Cole Mickens <cole.mickens@gmail.com>
@primeos
Copy link
Member

primeos commented Jan 9, 2021

I tested this with sway, alacritty, and xkbcli. Everything was working fine and I didn't notice any issues/regressions.
I'll squash and rebase it and then it should be good to go :)
(Feel free to merge and if you have any objections please raise them now as I'll likely merge it in a few hours.)

@primeos primeos merged commit ada4111 into NixOS:staging Jan 9, 2021
@primeos
Copy link
Member

primeos commented Jan 25, 2021

“Add libxkbregistry as configure-time optional library.” Is this included in the package? Can it be built separately?

I've had some time to look into this and opened #110773 with a brief reasoning for my approach. Feel free to add your thoughts/opinions or other feedback.

@primeos primeos mentioned this pull request Jan 25, 2021
10 tasks
@colemickens colemickens deleted the libxkbcommon branch December 30, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xkbcommon/libxkbcommon are behind (current 0.10.0, released 1.0.3)
6 participants