kernel-builder: Call either of install or zinstall #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that under specific conditions: - 2a5 hardware - -j22 the call to `make install zinstall` (simplified here) may break, with the installation of `System.map` happening in a manner where it fails the build. It was not trivial to reproduce elsewhere than on a 2a5 machine, for unknown reasons. It was also only observed on google-walleye, but there is no reason is shouldn't be failing on other devices too. Odd.
samueldr
commented
Dec 31, 2020
| ] | ||
| ++ optional (isCompressed != false) "zinstall" | ||
| installTargets = | ||
| if isCompressed != false then [ "zinstall" ] else [ "install" ] |
There was a problem hiding this comment.
Why the odd != false? This is why:
nix-repl> let isCompressed = "gz"; in if isCompressed then "zinstall" else "install"
error: value is a string while a Boolean was expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that under specific conditions:
the call to
make install zinstall(simplified here) may break, withthe installation of
System.maphappening in a manner where it failsthe build. It was not trivial to reproduce elsewhere than on a 2a5
machine, for unknown reasons.
It was also only observed on google-walleye, but there is no reason is
shouldn't be failing on other devices too.
Odd.
More details: