hidapi: fix cross build #108025
Closed
hidapi: fix cross build #108025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,7 @@ | |||
| { stdenv, fetchFromGitHub, autoreconfHook, pkgconfig, udev, libusb1 | |||
There was a problem hiding this comment.
Suggested change
| { stdenv, fetchFromGitHub, autoreconfHook, pkgconfig, udev, libusb1 | |
| { stdenv, fetchFromGitHub, autoreconfHook, pkg-config, udev, libusb1 |
| nativeBuildInputs = [ autoreconfHook pkgconfig ]; | ||
| nativeBuildInputs = [ | ||
| autoreconfHook | ||
| pkgconfig |
There was a problem hiding this comment.
Suggested change
| pkgconfig | |
| pkg-config |
Comment on lines
23
to
24
| buildInputs = [ ] | ||
| ++ stdenv.lib.optionals stdenv.isLinux [ libusb1 udev ]; |
There was a problem hiding this comment.
Suggested change
| buildInputs = [ ] | |
| ++ stdenv.lib.optionals stdenv.isLinux [ libusb1 udev ]; | |
| buildInputs = stdenv.lib.optionals stdenv.isLinux [ libusb1 udev ]; |
|
ok, this needs to be added conditionally |
|
pushed f651423 to staging-next |
|
Thanks for the fix. |
10 tasks
|
I pushed a cleanup PR on top, making this not only conditional on cross in #108044, and addressing the PR feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Running ofborg to assess the amount of rebuilds. Might need to make this a cross-only patch.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)