Change #8325: Make engine reliability independent of introduction date #8470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michicc
approved these changes
Dec 30, 2020
There was a problem hiding this comment.
Samu: you have 6 train engines available in 1860, let's test this
Samu: yep, all your 1860 engines got the same reliability: 98%
Samu: with the PR, they get: 89%, 83%, 96%, 81%, 86% and 84%
Samu: and they're still introduced at the same time
andythenorth: Samu results seem valid
andythenorth
added
bug
SamuXarick
deleted the
engine-reliability-independent-of-introduction-date
branch
LordAro
removed
the
backport requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
#8325
Engines that are introduced in the same date also have the same reliability. While it is more desirable for engines to be introduced simultaneously for NewGRF vehicle sets, it seems it isn't as desirable for the reliability, especially for players that use breakdowns.
Description
The problem is solved by not using the same random seed that is used for engine introduction to also generate reliability.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.