Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mopidy-scrobbler: init at 2.0.1 #107993

Merged
merged 3 commits into from Jan 1, 2021
Merged

mopidy-scrobbler: init at 2.0.1 #107993

merged 3 commits into from Jan 1, 2021

Conversation

jakeisnt
Copy link

Motivation for this change

Mopidy-Scrobbler is a Mopidy extensions maintained by the Mopidy organization. Many other Mopidy extensions maintained by them are already packaged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lovesegfault
Copy link
Member

Result of nixpkgs-review pr 107993 run on x86_64-linux 1

1 package built:
  • mopidy-scrobbler

lovesegfault
lovesegfault requested changes Dec 31, 2020
View reviewed changes
Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the sorting issue this is AOK

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 changed the title mopidy-scrobbler: init at 2.0.1 #93400 mopidy-scrobbler: init at 2.0.1 Dec 31, 2020
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107993 run on x86_64-linux 1

1 package built:
  • mopidy-scrobbler

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107993 run on x86_64-darwin 1

1 package built:
  • mopidy-scrobbler

SuperSandro2000
SuperSandro2000 requested changes Dec 31, 2020
View reviewed changes
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
maintainers: add jakeisnt
baf6480 
Sort jakeisnt in maintainer list

maintainers: add jakeisnt
@jakeisnt jakeisnt requested a review from otavio December 31, 2020 16:50
otavio
otavio suggested changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@otavio otavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to sort the packages in a commit before adding the new package? This makes this easier to review and keep the changes on individual and logical commits.

@jakeisnt
Copy link
Author

Would you mind to sort the packages in a commit before adding the new package? This makes this easier to review and keep the changes on individual and logical commits.

Sure.

What would you like the commit message to be?

Would you prefer the commit to sort the packages to be before or after the commit to add mopidy-scrobbler?

@otavio
Copy link
Contributor

otavio commented Dec 31, 2020

@jakeisnt I'd probably do it before.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107993 run on x86_64-darwin 1

1 package built:
  • mopidy-scrobbler

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107993 run on x86_64-linux 1

1 package built:
  • mopidy-scrobbler

@SuperSandro2000
Copy link
Member

Please change Reorder mopidy package declarations to mopidy: sort package declarations

@jakeisnt
Copy link
Author

jakeisnt commented Jan 1, 2021

Please change Reorder mopidy package declarations to mopidy: sort package declarations

This has been done.

@lovesegfault lovesegfault merged commit 79adc84 into NixOS:master Jan 1, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107993 run on x86_64-linux 1

1 package built:
  • mopidy-scrobbler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

@otavio otavio Awaiting requested review from otavio

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jakeisnt @lovesegfault @SuperSandro2000 @otavio @Janik-Haag