Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghidra: 9.2 -> 9.2.1 #108052

Merged
merged 1 commit into from Dec 31, 2020
Merged

ghidra: 9.2 -> 9.2.1 #108052

merged 1 commit into from Dec 31, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Dec 31, 2020 •
edited

Motivation for this change
  • version update
  • enable on x86_64-darwin
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
ghidra: 9.2 -> 9.2.1
688bf1f 
+ enable on x86_64-darwin
@ofborg ofborg bot requested review from ck3d and GovanifY December 31, 2020 15:20
GovanifY
GovanifY approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@GovanifY GovanifY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

otavio
otavio approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@otavio otavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#108052
1 package built:
ghidra-bin

LGTM.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108052 run on x86_64-darwin 1

1 package built:
  • ghidra-bin

@prusnak prusnak merged commit 72653c1 into NixOS:master Dec 31, 2020
@prusnak prusnak deleted the ghidra branch December 31, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otavio otavio otavio approved these changes

@GovanifY GovanifY GovanifY approved these changes

@ck3d ck3d Awaiting requested review from ck3d

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prusnak @SuperSandro2000 @otavio @GovanifY