Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3fs: fix dependencies #108059

Merged
merged 3 commits into from Dec 31, 2020
Merged

s3fs: fix dependencies #108059

merged 3 commits into from Dec 31, 2020

Conversation

teh
Copy link
Contributor

@teh teh commented Dec 31, 2020

Motivation for this change

python3Modules.s3fs is currently broken due to an upstream dependency change (e.g. https://hydra.nixos.org/job/nixpkgs/trunk/python37Packages.s3fs.x86_64-darwin).

This PR inits the missing dependencies at their most recent releases and fixes the s3fs build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 changed the title Add aiobotocore to fix s3fs s3fs: fix dependencies Dec 31, 2020
teh
teh commented Dec 31, 2020
View reviewed changes
Copy link
Contributor Author

@teh teh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

pkgs/development/python-modules/aioitertools/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/aiobotocore/default.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108059 run on x86_64-linux 1

9 packages built:
  • python37Packages.aiobotocore
  • python37Packages.aioitertools
  • python37Packages.s3fs
  • python38Packages.aiobotocore
  • python38Packages.aioitertools
  • python38Packages.s3fs
  • python39Packages.aiobotocore
  • python39Packages.aioitertools
  • python39Packages.s3fs

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108059 run on x86_64-darwin 1

9 packages built:
  • python37Packages.aiobotocore
  • python37Packages.aioitertools
  • python37Packages.s3fs
  • python38Packages.aiobotocore
  • python38Packages.aioitertools
  • python38Packages.s3fs
  • python39Packages.aiobotocore
  • python39Packages.aioitertools
  • python39Packages.s3fs

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108059 run on x86_64-linux 1

9 packages built:
  • python37Packages.aiobotocore
  • python37Packages.aioitertools
  • python37Packages.s3fs
  • python38Packages.aiobotocore
  • python38Packages.aioitertools
  • python38Packages.s3fs
  • python39Packages.aiobotocore
  • python39Packages.aioitertools
  • python39Packages.s3fs

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108059 run on x86_64-darwin 1

9 packages built:
  • python37Packages.aiobotocore
  • python37Packages.aioitertools
  • python37Packages.s3fs
  • python38Packages.aiobotocore
  • python38Packages.aioitertools
  • python38Packages.s3fs
  • python39Packages.aiobotocore
  • python39Packages.aioitertools
  • python39Packages.s3fs

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108059 run on x86_64-linux 1

9 packages built:
  • python37Packages.aiobotocore
  • python37Packages.aioitertools
  • python37Packages.s3fs
  • python38Packages.aiobotocore
  • python38Packages.aioitertools
  • python38Packages.s3fs
  • python39Packages.aiobotocore
  • python39Packages.aioitertools
  • python39Packages.s3fs

@SuperSandro2000 SuperSandro2000 merged commit 52d0ef0 into NixOS:master Dec 31, 2020
@fabaff fabaff mentioned this pull request Aug 23, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teh @SuperSandro2000