gcc: allow stripping gcc libraries #108060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
approved these changes
Dec 31, 2020
|
As I understand it this doesn't yet fix the issue of inadvertant glibc references when cross compiling to a different arch is that correct? Is that because strip would otherwise mis-interpret the libraries involved? |
|
I can verify this does indeed solve the inclusion of glibc when using pkgsMusl or crossSystem x86_64-unknown-linux-musl. Of course attempting the cross compiled (aarch64-unknown-linux-musl) does not yet remove the glibc dependency as expected given the changes here |
teburd
approved these changes
Jan 12, 2021
matthewbauer
force-pushed
the
strip-musl-gcc
branch
from
247fc8f
to
e1fa7be
Compare
matthewbauer
requested review from
edolstra,
infinisil,
Mic92,
nbp and
zowoq
as code owners
When cross compiling to the same kernel / arch combination, it is safe to use strip of libraries. This happens when cross-compiling musl programs. dontStrip is now set in each gcc compiler instead of in gcc/builder.sh. Fixes NixOS#75476
matthewbauer
force-pushed
the
strip-musl-gcc
branch
from
e1fa7be
to
4bdcddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross compiling to the same kernel / arch combination, it is safe
to use strip of libraries. This happens when cross-compiling musl
programs. dontStrip is now set in each gcc compiler instead of in
gcc/builder.sh.
Fixes #75476