Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] gnupg: 2.2.25 -> 2.2.26 #108037

Merged
merged 1 commit into from Jan 4, 2021
Merged

[staging] gnupg: 2.2.25 -> 2.2.26 #108037

merged 1 commit into from Jan 4, 2021

Conversation

lukebfox
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from peti, vrthra and fpletz December 31, 2020 12:35
@SuperSandro2000
Copy link
Member

Please target staging with this mass rebuild.

@stigtsp
Copy link
Member

stigtsp commented Dec 31, 2020 •
edited

Hi there!

2.2.26 is released, is there a reason why this bump is for 2.2.25?

https://lists.gnupg.org/pipermail/gnupg-announce/2020q4/000451.html

@lukebfox lukebfox changed the base branch from master to staging December 31, 2020 16:20
@lukebfox lukebfox changed the title gnupg: 2.2.24 -> 2.2.25 [staging] gnupg: 2.2.24 -> 2.2.25 Dec 31, 2020
@lukebfox lukebfox changed the title [staging] gnupg: 2.2.24 -> 2.2.25 [staging] gnupg: 2.2.24 -> 2.2.26 Dec 31, 2020
@otavio
Copy link
Contributor

otavio commented Dec 31, 2020

@lukebfox, the branch has conflict. Please check.

@lukebfox
Copy link
Member Author

I wasn't aware of this release because I was using the project's GitHub mirror's tags as a release reference so I'm bumping it to 2.2.26 now.

@ajs124
Copy link
Member

ajs124 commented Dec 31, 2020

Staging already has 2.2.25 (not 2.2.24). Also, this should be rebased instead of having staging merged into it.

@lukebfox lukebfox changed the title [staging] gnupg: 2.2.24 -> 2.2.26 [staging] gnupg: 2.2.26 -> 2.2.26 Jan 1, 2021
@lukebfox lukebfox changed the title [staging] gnupg: 2.2.26 -> 2.2.26 [staging] gnupg: 2.2.25 -> 2.2.26 Jan 1, 2021
@lukebfox
Copy link
Member Author

lukebfox commented Jan 1, 2021

Should be all good now thanks

@FRidh FRidh merged commit 374e303 into NixOS:staging Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

@vrthra vrthra Awaiting requested review from vrthra

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lukebfox @SuperSandro2000 @stigtsp @otavio @ajs124 @FRidh