Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gospider,pythonPackages.vcver,pythonPackages.pysvn,netease-music-tui: Small fixes #107990

Merged
merged 4 commits into from Dec 31, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Dec 30, 2020

Result of nixpkgs-review pr 107990 1

4 packages failed to build:
  • python37Packages.pysvn
  • python38Packages.pysvn
  • python39Packages.pysvn
  • rabbitvcs
9 packages built:
  • python37Packages.deepmerge
  • python37Packages.pyipp
  • python37Packages.vcver
  • python38Packages.deepmerge
  • python38Packages.pyipp
  • python38Packages.vcver
  • python39Packages.deepmerge
  • python39Packages.pyipp
  • python39Packages.vcver

@mweinelt
Copy link
Member

Check whether the following modules can be imported: pysvn
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<string>", line 1, in <lambda>
  File "/nix/store/401hv5vy6jm6wyppmlaalakdlsrzchc6-python3-3.7.9/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 965, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'pysvn'

Copy link
Contributor

@otavio otavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! small but great fixes. :-)

@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107990 run on x86_64-linux 1

13 packages built:
  • python37Packages.deepmerge
  • python37Packages.pyipp
  • python37Packages.pysvn
  • python37Packages.vcver
  • python38Packages.deepmerge
  • python38Packages.pyipp
  • python38Packages.pysvn
  • python38Packages.vcver
  • python39Packages.deepmerge
  • python39Packages.pyipp
  • python39Packages.pysvn
  • python39Packages.vcver
  • rabbitvcs

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 107990 run on x86_64-darwin 1

6 packages failed to build:
  • python37Packages.pyipp
  • python37Packages.pysvn
  • python38Packages.pyipp
  • python38Packages.pysvn
  • python39Packages.pyipp
  • python39Packages.pysvn
6 packages built:
  • python37Packages.deepmerge
  • python37Packages.vcver
  • python38Packages.deepmerge
  • python38Packages.vcver
  • python39Packages.deepmerge
  • python39Packages.vcver

pysvn

  Compile: generate_svn_error_codes/generate_svn_error_codes.cpp into generate_svn_error_codes.o                                                                                              /nix/store/rdbq2q75ysh13gis328k7vwwf4s22hvw-bash-4.4-p23/bin/bash: g++: command not found                                                                                                   make: *** [Makefile:203: generate_svn_error_codes.o] Error 127

pyipp fails because of sandbox.

@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107990 run on x86_64-linux 1

13 packages built:
  • python37Packages.deepmerge
  • python37Packages.pyipp
  • python37Packages.pysvn
  • python37Packages.vcver
  • python38Packages.deepmerge
  • python38Packages.pyipp
  • python38Packages.pysvn
  • python38Packages.vcver
  • python39Packages.deepmerge
  • python39Packages.pyipp
  • python39Packages.pysvn
  • python39Packages.vcver
  • rabbitvcs

@ofborg ofborg bot requested a review from mweinelt December 31, 2020 04:42
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 107990 run on x86_64-darwin 1

6 packages failed to build:
  • python37Packages.pyipp
  • python37Packages.pysvn
  • python38Packages.pyipp
  • python38Packages.pysvn
  • python39Packages.pyipp
  • python39Packages.pysvn
6 packages built:
  • python37Packages.deepmerge
  • python37Packages.vcver
  • python38Packages.deepmerge
  • python38Packages.vcver
  • python39Packages.deepmerge
  • python39Packages.vcver

@SuperSandro2000 SuperSandro2000 merged commit edf334d into NixOS:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants