Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luxcorerender: Fix build #108051

Merged
merged 1 commit into from Jan 6, 2021
Merged

luxcorerender: Fix build #108051

merged 1 commit into from Jan 6, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Hodapp87 December 31, 2020 15:11
otavio
otavio suggested changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@otavio otavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit log is incomplete and does not explain what it fixes.

@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108051 run on x86_64-linux 1

1 package built:
  • luxcorerender

@SuperSandro2000
luxcorerender: Fix build
5d1c04d 
CL/cl.hpp was missing which made the build fail.
otavio
otavio approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@otavio otavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :-)

@SuperSandro2000 SuperSandro2000 merged commit cde7613 into NixOS:master Jan 6, 2021
@SuperSandro2000 SuperSandro2000 deleted the luxcorerender-build branch January 6, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otavio otavio otavio approved these changes

@Hodapp87 Hodapp87 Awaiting requested review from Hodapp87

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @otavio