Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] Backport ShellHub package and service #108001

Merged
merged 3 commits into from Dec 31, 2020
Merged

[20.09] Backport ShellHub package and service #108001

merged 3 commits into from Dec 31, 2020

Conversation

otavio
Copy link
Contributor

@otavio otavio commented Dec 31, 2020

Motivation for this change

This is a backport of #104419.

We aim to ease the use of ShellHub and NixOS is one of the distros we'd like to support. It is working very well on our machines.

We believe the backport, even not being a bug fix, this is a new and isolated package and service thus providing no regression risks.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@otavio
maintainer-list: add otavio
1f86266 
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
(cherry picked from commit c95a08d)
@otavio
shellhub-agent: initial expression at 0.4.2
487b5b4 
ShellHub is a modern SSH server for remotely accessing Linux devices via
command line (using any SSH client) or web-based user interface,
designed as an alternative to _sshd_.

Think ShellHub as centralized SSH for the the edge and cloud computing.

More information about the project in:

 - https://shellhub.io
 - https://github.com/shellhub-io/shellhub

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
(cherry picked from commit f5d54c8)
@otavio
nixos/shellhub-agent: initial service expression
b697faa 
This provides the service to configure the ShellHub Agent.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
(cherry picked from commit 06edbab)
@ofborg ofborg bot requested a review from kalbasit December 31, 2020 00:39
@thiagokokada
Copy link
Contributor

thiagokokada commented Dec 31, 2020 •
edited

Result of nixpkgs-review pr 108001 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • shellhub-agent

The binary did a segfault, but maybe this is because I didn't run it using the module.

BTW, I don't know what is the policy for backporting new packages to a stable release. I am only approving it here since it seems harmless.

jonringer
jonringer approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 108001 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • shellhub-agent

@jonringer jonringer merged commit 3bd6c7a into NixOS:release-20.09 Dec 31, 2020
@otavio otavio deleted the backport-20.09/shellhub branch February 2, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@jonringer jonringer jonringer approved these changes

@infinisil infinisil Awaiting requested review from infinisil

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@otavio @thiagokokada @jonringer