Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvmaf: 1.5.3 -> 2.1.0 #108002

Merged
merged 1 commit into from Jan 7, 2021
Merged

libvmaf: 1.5.3 -> 2.1.0 #108002

merged 1 commit into from Jan 7, 2021

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 31, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor Author

marsam commented Dec 31, 2020

@GrahamcOfBorg build ffmpeg-full

@ofborg ofborg bot requested a review from cfsmp3 December 31, 2020 00:39
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108002 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • libsForQt512.kdenlive
  • libsForQt514.kdenlive
  • python37Packages.baselines
  • python37Packages.rl-coach
30 packages built:
  • MIDIVisualizer
  • ffmpeg-full
  • handbrake
  • hydron
  • libsForQt5.kdenlive (kdeApplications.kdenlive ,libsForQt515.kdenlive)
  • libvmaf
  • liquidsoap
  • manim
  • olive-editor
  • printrun
  • python37Packages.gym
  • python37Packages.moderngl-window
  • python37Packages.pydub
  • python37Packages.pyglet
  • python37Packages.pytmx
  • python37Packages.roboschool
  • python38Packages.gym
  • python38Packages.moderngl-window
  • python38Packages.pydub
  • python38Packages.pyglet
  • python38Packages.pytmx
  • python38Packages.roboschool
  • python39Packages.gym
  • python39Packages.moderngl-window
  • python39Packages.pydub
  • python39Packages.pyglet
  • python39Packages.pytmx
  • python39Packages.roboschool
  • soundkonverter
  • webcamoid

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

ffmpeg-full.log:

`gpl3` is a deprecated license, check if project uses `gpl3Plus` or `gpl3Only` and change `meta.license` accordingly.

Near pkgs/development/libraries/ffmpeg-full/default.nix:473:5:

    |
473 |     license = (
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

handbrake.log:
`gpl2` is a deprecated license, check if project uses `gpl2Plus` or `gpl2Only` and change `meta.license` accordingly.

Near pkgs/applications/video/handbrake/default.nix:145:5:

    |
145 |     license = licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

liquidsoap.log:
`gpl2` is a deprecated license, check if project uses `gpl2Plus` or `gpl2Only` and change `meta.license` accordingly.

Near pkgs/tools/audio/liquidsoap/full.nix:71:5:

   |
71 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

olive-editor.log:
`gpl3` is a deprecated license, check if project uses `gpl3Plus` or `gpl3Only` and change `meta.license` accordingly.

Near pkgs/applications/video/olive-editor/default.nix:34:5:

   |
34 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

soundkonverter.log:
`gpl2` is a deprecated license, check if project uses `gpl2Plus` or `gpl2Only` and change `meta.license` accordingly.

Near pkgs/applications/audio/soundkonverter/default.nix:77:5:

   |
77 |     license = lib.licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
�[1;33mwarning: unnecessary-parallel-building�[0m
Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

Near pkgs/development/libraries/qt-5/mkDerivation.nix:25:5:

   |
25 |     enableParallelBuilding = args.enableParallelBuilding or true;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108002 run on x86_64-darwin 1

15 packages marked as broken and skipped:
  • liquidsoap
  • python37Packages.baselines
  • python37Packages.gym
  • python37Packages.pyglet
  • python37Packages.pytmx
  • python37Packages.rl-coach
  • python37Packages.roboschool
  • python38Packages.gym
  • python38Packages.pyglet
  • python38Packages.pytmx
  • python38Packages.roboschool
  • python39Packages.gym
  • python39Packages.pyglet
  • python39Packages.pytmx
  • python39Packages.roboschool
1 package failed to build:
  • manim
8 packages built:
  • ffmpeg-full
  • handbrake
  • hydron
  • libvmaf
  • olive-editor
  • python37Packages.pydub
  • python38Packages.pydub
  • python39Packages.pydub

manim:
sandbox-exec: pattern serialization length 248862 exceeds maximum (65535)

@ofborg ofborg bot requested a review from cfsmp3 January 6, 2021 04:35
@marsam marsam merged commit 4aa45ae into NixOS:master Jan 7, 2021
@marsam marsam deleted the update-libvmaf branch January 7, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@cfsmp3 cfsmp3 Awaiting requested review from cfsmp3

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @SuperSandro2000 @cfsmp3