Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovito: 3.3.1 -> 3.3.5 #108038

Closed
wants to merge 1 commit into from
Closed

ovito: 3.3.1 -> 3.3.5 #108038

wants to merge 1 commit into from

Conversation

siraben
Copy link
Member

@siraben siraben commented Dec 31, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

Running nixpkgs-review on this froze my machine almost three times cause it used more than 12GB of RAM...

@siraben
Copy link
Member Author

siraben commented Dec 31, 2020

So sorry! I think it would be better off if someone else tried upgrading it, as I'm not familiar with this package.

@siraben siraben closed this Dec 31, 2020
@siraben siraben deleted the ovito-update branch December 31, 2020 16:28
@SuperSandro2000
Copy link
Member

I build python38Packages.ovito successfully which needs to be enough for now.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Dec 31, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siraben @SuperSandro2000 @prusnak