Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-flamegraph: 0.3.0 -> 0.4.0 and clean up #108064

Merged
merged 1 commit into from Jan 3, 2021
Merged

cargo-flamegraph: 0.3.0 -> 0.4.0 and clean up #108064

merged 1 commit into from Jan 3, 2021

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Dec 31, 2020

Motivation for this change
  • Bump version.
  • Add update script.
  • Set perf through environment PERF which is available in 0.4.0 , instead of PATH.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" 
    1 package built:
cargo-flamegraph
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from killercup December 31, 2020 18:07
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108064 run on x86_64-linux 1

1 package built:
  • cargo-flamegraph

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108064 run on x86_64-darwin 1

1 package built:
  • cargo-flamegraph

@Ma27 Ma27 merged commit 0d9e4d2 into NixOS:master Jan 3, 2021
@oxalica oxalica deleted the bump/cargo-flamegraph branch January 4, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@killercup killercup Awaiting requested review from killercup

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxalica @SuperSandro2000 @Ma27