Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patroni: 1.6.5 -> 2.0.1 #108019

Closed
wants to merge 2 commits into from
Closed

patroni: 1.6.5 -> 2.0.1 #108019

wants to merge 2 commits into from

Conversation

rmcgibbo
Copy link
Contributor

Motivation for this change

Fix #107425 (patroni tests timing out) by upgrading package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rmcgibbo rmcgibbo changed the title Patroni patroni: 1.6.5 -> 2.0.1 Dec 31, 2020
@rmcgibbo
Copy link
Contributor Author

Result of nixpkgs-review pr 108019 run on x86_64-linux 1

4 packages built:
  • patroni
  • python37Packages.pysyncobj
  • python38Packages.pysyncobj
  • python39Packages.pysyncobj

@ofborg ofborg bot requested a review from limeytexan December 31, 2020 04:47
jonringer
jonringer reviewed Dec 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise diff lgtm

pkgs/development/python-modules/pysyncobj/default.nix
pytestFlagsArray = [ "test_syncobj.py" ];

meta = with lib; {
description = "A library for replicating your python class between multiple servers, based on raft protocol";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be succinct

Suggested change
description = "A library for replicating your python class between multiple servers, based on raft protocol";
description = "Replicate your python class between multiple servers, based on raft protocol";

limeytexan
limeytexan approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@limeytexan limeytexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes and looks good to me - many thanks!

@arianvp
Copy link
Member

arianvp commented Jan 29, 2021

Could rebase this to solve the conflict?

@rmcgibbo
Copy link
Contributor Author

rmcgibbo commented Feb 5, 2021

It looks like this was done in #111720 anyways.

@rmcgibbo rmcgibbo closed this Feb 5, 2021
@rmcgibbo rmcgibbo deleted the patroni branch February 5, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@prusnak prusnak prusnak approved these changes

@limeytexan limeytexan limeytexan approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

patroni tests fail and hang up on master
6 participants
@rmcgibbo @arianvp @prusnak @jonringer @limeytexan @SuperSandro2000