Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.slixmpp: 1.5.2 -> 1.6.0 #108034

Merged
merged 1 commit into from Dec 31, 2020
Merged

python3Packages.slixmpp: 1.5.2 -> 1.6.0 #108034

merged 1 commit into from Dec 31, 2020

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Dec 31, 2020

Motivation for this change

Update to latest upstream release 1.6.0.

Sorry, no changelog is available (Commit log).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Dec 31, 2020

Result of nixpkgs-review pr 108034 1

10 packages built:
  • poezio (python38Packages.poezio)
  • prometheus-xmpp-alerts
  • python37Packages.aioharmony
  • python37Packages.poezio
  • python37Packages.slixmpp
  • python38Packages.aioharmony
  • python38Packages.slixmpp
  • python39Packages.aioharmony
  • python39Packages.poezio
  • python39Packages.slixmpp

otavio
otavio approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@otavio otavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108034 run on x86_64-darwin 1

4 packages marked as broken and skipped:
  • poezio
  • python37Packages.poezio
  • python38Packages.poezio
  • python39Packages.poezio
7 packages built:
  • prometheus-xmpp-alerts
  • python37Packages.aioharmony
  • python37Packages.slixmpp
  • python38Packages.aioharmony
  • python38Packages.slixmpp
  • python39Packages.aioharmony
  • python39Packages.slixmpp

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108034 run on x86_64-linux 1

10 packages built:
  • poezio (python38Packages.poezio)
  • prometheus-xmpp-alerts
  • python37Packages.aioharmony
  • python37Packages.poezio
  • python37Packages.slixmpp
  • python38Packages.aioharmony
  • python38Packages.slixmpp
  • python39Packages.aioharmony
  • python39Packages.poezio
  • python39Packages.slixmpp

@SuperSandro2000 SuperSandro2000 merged commit 270e996 into NixOS:master Dec 31, 2020
@fabaff fabaff deleted the bump-slixmpp branch December 31, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otavio otavio otavio approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @SuperSandro2000 @otavio