Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asciidoctor version and add bibtex extension #106971

Closed
wants to merge 2 commits into from

Conversation

nicknovitski
Copy link
Contributor

Motivation for this change

Closes #106364

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) 890965608 -> 892923424 (.2% increase)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nicknovitski
Copy link
Contributor Author

A lot of packages use asciidoctor to build their documentation, so the nixpkgs-review is very large.

@nicknovitski nicknovitski changed the base branch from master to staging December 29, 2020 19:59
@@ -1,4 +1,4 @@
{ lib, bundlerApp, makeWrapper,
{ lib, bundlerApp, makeWrapper, libxslt,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don' think this input is used anywhere.

@stale
Copy link

stale bot commented Sep 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asciidoctor: add bibtex support
2 participants