Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.ranger-vim: Use *another* ranger.vim #106970

Closed
wants to merge 2 commits into from
Closed

vimPlugins.ranger-vim: Use *another* ranger.vim #106970

wants to merge 2 commits into from

Conversation

jD91mZM2
Copy link
Member

@jD91mZM2 jD91mZM2 commented Dec 15, 2020 •
edited

Motivation for this change

I think this one is better, personally. CC @cjpbirkbeck who initially added the current ranger.vim to nixpkgs in #46696. Is this one equal or better for your purposes too?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jD91mZM2
vimPlugins: update
b454c3c
@jD91mZM2
vimPlugins.ranger-vim: Use *another* ranger.vim
9fac85a 
I think this one is better, personally. CC @cjpbirkbeck who initially
added the current ranger.vim to nixpkgs in NixOS#46696. Is this one equal or
better for your purposes too?
@jD91mZM2 jD91mZM2 changed the title Ranger vim vimPlugins.ranger-vim: Use *another* ranger.vim Dec 15, 2020
@ofborg ofborg bot added the 6.topic: vim label Dec 15, 2020
@ofborg ofborg bot requested review from jagajaga and jorsn December 15, 2020 16:50
@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@teto
Copy link
Member

teto commented Dec 2, 2021

sadly we won't see another commit from @jD91mzZM2 thus closing

@teto teto closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@jagajaga jagajaga Awaiting requested review from jagajaga

@jorsn jorsn Awaiting requested review from jorsn

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jD91mZM2 @teto @SuperSandro2000