Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plantuml: 1.2020.19 -> 1.2020.26 #108563

Merged
merged 1 commit into from Jan 14, 2021
Merged

plantuml: 1.2020.19 -> 1.2020.26 #108563

merged 1 commit into from Jan 14, 2021

Conversation

mkuettel
Copy link

@mkuettel mkuettel commented Jan 6, 2021

Plantuml complains that it's too old when a diagram is generated to PNG an
error occurs.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

@ofborg eval

@ofborg ofborg bot requested a review from bjornfor January 6, 2021 12:48
@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 6, 2021 •
edited

Result of nixpkgs-review pr 108563 run on x86_64-linux 1

4 packages built:
  • plantuml
  • python37Packages.sphinxcontrib_plantuml
  • python38Packages.sphinxcontrib_plantuml
  • python39Packages.sphinxcontrib_plantuml

Tested with this diagram:

@startuml
Alice -> Bob: Authentication Request
Bob --> Alice: Authentication Response

Alice -> Bob: Another authentication Request
Alice <-- Bob: Another authentication Response
@enduml

Result:
test

thiagokokada
thiagokokada reviewed Jan 6, 2021
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash your commits and leave only the plantuml related one.

Also, there is a typo in your commit: planuml -> plantuml.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108563 run on x86_64-linux 1

4 packages built:
  • plantuml
  • python37Packages.sphinxcontrib_plantuml
  • python38Packages.sphinxcontrib_plantuml
  • python39Packages.sphinxcontrib_plantuml

@SuperSandro2000 SuperSandro2000 changed the title planuml: 1.2020.19 -> 1.2020.26 plantuml: 1.2020.19 -> 1.2020.26 Jan 6, 2021
@SuperSandro2000
Copy link
Member

I think the other two commits are unrelated to this one. Please clean that up.

@mogria
plantuml: 1.2020.22 -> 1.2020.26
2025ca9 
PlantUML complains that it's too old when a diagram is generated to PNG an
error occurs.
@mkuettel
Copy link
Author

Fixed and force pushed.

thiagokokada
thiagokokada reviewed Jan 13, 2021
View reviewed changes
pkgs/tools/misc/plantuml/default.nix
@@ -28,7 +28,7 @@ stdenv.mkDerivation rec {
homepage = "http://plantuml.sourceforge.net/";
# "plantuml -license" says GPLv3 or later
license = licenses.gpl3Plus;
maintainers = with maintainers; [ bjornfor ];
maintainers = with maintainers; [ bjornfor Mogria ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was really confused that the user of this commit and the author of PR doesn't match, but I will just assume this is another account.

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 108563 run on x86_64-linux 1

4 packages built:
  • plantuml
  • python37Packages.sphinxcontrib_plantuml
  • python38Packages.sphinxcontrib_plantuml
  • python39Packages.sphinxcontrib_plantuml

@SuperSandro2000 SuperSandro2000 merged commit 1fa1ae3 into NixOS:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@bjornfor bjornfor Awaiting requested review from bjornfor

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mkuettel @SuperSandro2000 @thiagokokada @Janik-Haag @mogria