qemu-guest: remove security.rngd setting #108544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajs124
reviewed
Jan 6, 2021
| @@ -15,5 +15,5 @@ | |||
| hwclock -s | |||
| ''; | |||
|
|
|||
| security.rngd.enable = lib.mkDefault false; | |||
There was a problem hiding this comment.
Sorry, that's what I had intended, instead I accidentally just reverted c27360a.
Fixed.
Since release 20.09 `rngd.enable` defaults to false, so this setting is redundant. Also fix the `qemu-quest` section of the manual that incorrectly claimed that `rngd` was enabled.
erikarvstedt
force-pushed
the
qemu-guest
branch
from
10d311f
to
93d6296
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of commit msg
Since release 20.09
rngd.enabledefaults to false, so this setting is redundant.Also fix the
qemu-questsection of the manual that incorrectly claimed thatrngdwas enabled.Things done