Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: flatbuffers: fix compilation errors by upgrading to latest master #108502

Conversation

esotericnonsense
Copy link
Contributor

This is a placeholder. I'm not sure what the appropriate strategy is here, but 1.12.0 fails to build now and there is no newer release tag yet.

  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions

@veprbl
Copy link
Member

veprbl commented Jan 6, 2021

Should be instead adding

patches = [
  (fetchpatch {
    url = "https://github.com/google/flatbuffers/commit/988164f6e1675bbea9c852e2d6001baf4d1fcf59.diff";
    sha256 = "08mmhf10schbcy82mn15srih47pf3pnkpbh92dyl8vhia8l0i0g5";
  })
];

@esotericnonsense
Copy link
Contributor Author

This has been fixed by #108415.

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants