Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ott-mode: Factor our from ott #108507

Merged
merged 2 commits into from Jan 10, 2021
Merged

ott-mode: Factor our from ott #108507

merged 2 commits into from Jan 10, 2021

Conversation

Ericson2314
Copy link
Member

Motivation for this change

ott-mode: Init (version inherited from ott)

This way it is pre-compiled.

ott: Don't also install emacs mode

There is now a separate package for that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ericson2314
ott-mode: Init (version inherited from ott)
0f52f30 
This way it is pre-compiled.
@Ericson2314
ott: Don't also install emacs mode
4eb1366 
There is now a separate package for that.
@ofborg ofborg bot added the 6.topic: emacs label Jan 5, 2021
@Ericson2314 Ericson2314 merged commit 05b5b54 into NixOS:master Jan 10, 2021
@Ericson2314 Ericson2314 deleted the ott-mode branch January 10, 2021 19:31
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108507 run on x86_64-linux 1

1 package built:
  • ott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@adisbladis adisbladis Awaiting requested review from adisbladis

@jwiegley jwiegley Awaiting requested review from jwiegley

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @SuperSandro2000