-
-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified GUI buttons for renaming and scrolling to entities #8455
Conversation
587c4f2
to
178a773
Compare
I quite like the new scroll buttons. Can't comment on renaming things as I almost never do so. Your idea of having the company window location scroll to the HQ makes sense to me. |
I really like what you did here! It is very awesome :D Code looks good; I am surprised it is only this few amount of lines of code .. There is, however, one thing that pisses off my OCD: the rename icon: It is not centered :( Also, I did not expect the letter A, honestly. I was more expecting a pencil. But that might be fully my bias. Here are some other icons people use for rename: But, as always, this is purely personal preference. The alignment, however, is not :D Sorry :P |
I second the pencil suggestion, although the 'A' doesn't bother me. Also, other icons (close, pin, etc) only use black and are a higher resolution. I know these are stand-in sprites, but it's something to keep in mind when choosing the final graphics. |
Eye-icon of the first is much more clear to me (the second doesn't really look like an eye, sorry ..). Pencil both look good to me .. second maybe slightly better than the first. My 2 cents :) |
@LC-Zorg: The icons added here have to fit with the original base graphics. |
Some observations after a quick test:
|
178a773
to
e9b079c
Compare
I cleaned up the tooltip texts, decided for the icon, and resized the icon so it fits in with the original baseset. |
Did all kinds of testing with all the windows changed; looks really good to me, couldn't find any weirdness. This is an OK for me. I did not approve, as @glx22 had some open comments I could not parse so not validate that they were fixed. If he is happy with it, let's merge this! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the fixed tooltips
This update reflects OpenTTD/OpenTTD#8455.
This update reflects OpenTTD/OpenTTD#8455.
Motivation / Problem
Many windows have some button to rename the entity, scroll to the entity, or open an extra viewport at the entity's location.
Previous ideas to unify or change this are:
Description
This PR adds small icon buttons to the window title bars:
Overview of changes:
Limitations
The sprites are placeholder sprites. If the concept is liked, maybe someone draws prettier ones.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.